Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary #23005

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jan 9, 2025

Redundant files in test/hotspot/jtreg/runtime/Dictionary, ClassForName.java and test.policy

Left over after SM removal tasks:
8341916: Remove ProtectionDomain related hotspot code and tests

ClassForName.java was built by test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23005/head:pull/23005
$ git checkout pull/23005

Update a local copy of the PR:
$ git checkout pull/23005
$ git pull https://git.openjdk.org/jdk.git pull/23005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23005

View PR using the GUI difftool:
$ git pr show -t 23005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23005.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
  • 3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
  • 2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
  • ceae2b9: 8347121: Add missing @serial tags to module java.base
  • 8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
  • 765b9e6: 8346706: RISC-V: Add available registers to hs_err
  • d66737e: 8341097: GHA: Demote Mac x86 jobs to build only
  • dff5719: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
  • 82e16ba: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
  • 33f9be8: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
  • ... and 34 more: https://git.openjdk.org/jdk/compare/c8a9dd3a027781d006850c028714a62903c487d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@kevinjwalls The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 9, 2025
@kevinjwalls kevinjwalls marked this pull request as ready for review January 9, 2025 13:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding these. Looks like a trivial change assuming GHA doesn't find any unintended uses of these files.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants