-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary #23005
base: master
Are you sure you want to change the base?
8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary #23005
Conversation
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@kevinjwalls The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding these. Looks like a trivial change assuming GHA doesn't find any unintended uses of these files.
Redundant files in test/hotspot/jtreg/runtime/Dictionary, ClassForName.java and test.policy
Left over after SM removal tasks:
8341916: Remove ProtectionDomain related hotspot code and tests
ClassForName.java was built by test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23005/head:pull/23005
$ git checkout pull/23005
Update a local copy of the PR:
$ git checkout pull/23005
$ git pull https://git.openjdk.org/jdk.git pull/23005/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23005
View PR using the GUI difftool:
$ git pr show -t 23005
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23005.diff
Using Webrev
Link to Webrev Comment