Skip to content

Commit

Permalink
Apply suggestions from @yardasol code review
Browse files Browse the repository at this point in the history
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
  • Loading branch information
jtramm and yardasol authored Jan 24, 2025
1 parent eb5bd7f commit b7482af
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions docs/source/methods/variance_reduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Variance Reduction
Introduction
------------

Transport problems can sometimes infolve a significant degree of attenuation
Transport problems can sometimes involve a significant degree of attenuation
between the neutron source and a detector (tally) region, which can result in a
flux differential of ten orders of magnitude (or more) throughout the simulation
domain. As Monte Carlo uncertainties tend to be inversely proportional to the
Expand All @@ -23,7 +23,7 @@ Variance reduction techniques aim to either flatten the global uncertainty
distribution, such that all regions of phase space have a fairly similar
uncertainty, or to reduce the uncertainty in specific locations (such as a
detector). There are two strategies available in OpenMC for variance reduction:
the Monte Carlo MAGIC method, and with FW-CADIS. Both strategies work by
the Monte Carlo MAGIC method, and the FW-CADIS method. Both strategies work by
developing a weight window mesh, which can be utilized by subsequent Monte Carlo
solves to split particles heading towards areas of lower flux densities while
terminating particles in higher flux regions -- all while maintaining a fair
Expand All @@ -34,7 +34,7 @@ MAGIC Method
------------

The MAGIC method is an iterative technique that uses spatial flux information
(:math:`\phi(r)`) obtained from a normal Monte Carlo solve to produce weight
:math:`\phi(r)` obtained from a normal Monte Carlo solve to produce weight
windows (:math:`\w(r)`) that can be utilized by a subsequent iteration of Monte
Carlo. While the first generation of weight windows produced may only help to
reduce variance slightly, use of these weights to generate another set of weight
Expand Down Expand Up @@ -77,7 +77,7 @@ and then trace it backwards (upscattering in energy), until we sample the point
where it was born from.

The FW-CADIS method produces weight windows for global variance reduction given
adjoint flux information throughout the entire domain. It is defined in Equation
adjoint flux information throughout the entire domain. The weight window lower bound is defined in Equation
:eq:`fw_cadis`, and also involves a normalization step not shown here.

.. math::
Expand Down
4 changes: 2 additions & 2 deletions docs/source/usersguide/variance_reduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ steps required to both generate and then apply weight windows.
Generating Weight Windows with MAGIC
------------------------------------

As discussed in the methods section, MAGIC is an iterative method that uses flux
As discussed in the :ref:`methods section <methods_variance_reduction>`, MAGIC is an iterative method that uses flux
tally information from a Monte Carlo simulation to produce weight windows for a
user defined mesh. While generating the weight windows, OpenMC is capable of
applying the weight windows generated from a previous batch while processing the
Expand Down Expand Up @@ -127,7 +127,7 @@ description of how to enable and setup random ray mode can be found in the
Using Weight Windows
--------------------

To use a "weight_windows.h5" weight window file with OpenMC's Monte Carlo
To use a ``weight_windows.h5`` weight window file with OpenMC's Monte Carlo
solver, the python input just needs to load the h5 file::

settings.weight_window_checkpoints = {'collision': True, 'surface': True}
Expand Down

0 comments on commit b7482af

Please sign in to comment.