Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: test for dataset comparison and ignore fields #1370

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

LennartPurucker
Copy link
Contributor

See: #981 and #577

Closes #981
Closes #577

Co-authored-by: ArlindKadra ArlindKadra@users.noreply.github.com

Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, not really sure on the full logic of the equality for datasets but in terms of the change and test, looks good!

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (82d8ffa) to head (edb0090).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1370      +/-   ##
===========================================
+ Coverage    84.05%   84.17%   +0.11%     
===========================================
  Files           38       38              
  Lines         5301     5303       +2     
===========================================
+ Hits          4456     4464       +8     
+ Misses         845      839       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LennartPurucker LennartPurucker merged commit 8fbf39e into develop Oct 16, 2024
12 of 13 checks passed
@LennartPurucker LennartPurucker deleted the test_comparisons branch October 16, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittest Dataset Equality
3 participants