ISSUE-21: Fix specifying count on queries via the global properties #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
reviewed
Jan 7, 2025
Comment on lines
-20
to
-25
| public Integer preferredPageSize() { | ||
| if (size() == null) { | ||
| setSize(globalPropertyService.getGlobalProperty(FhirConstants.OPENMRS_FHIR_DEFAULT_PAGE_SIZE, 10)); | ||
| } | ||
| return size(); | ||
| } |
There was a problem hiding this comment.
So from what you gathered, you mean this is never invoked?
There was a problem hiding this comment.
@samuelmale This is invoked but never has an impact since the size will always be set via the superclass. So I am fixing this by adding the count param earlier before the query is made. See here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelmale This PR has two major changes
I am removing the preferredPageSize method because it is redundant. The size is being set in the constructor. See the super class here and how it sets size with the size of the patient list.
I am setting the count param with the GP value seeing that different servers default to different values i.e 10. This is related to point 1 above that we never get chance to specify the count.
The rest of the changes are mainly formatting changes