Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EA-211: Expose getLocationThatSupportsVisit RESTfully #254

Merged
merged 1 commit into from
Nov 12, 2024
Merged

EA-211: Expose getLocationThatSupportsVisit RESTfully #254

merged 1 commit into from
Nov 12, 2024

Conversation

mogoodrich
Copy link
Member

No description provided.

@mogoodrich mogoodrich requested review from mseaton and ibacher November 8, 2024 17:44
mseaton
mseaton reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but remind me why we need this? Doesn't the core location endpoint allow searching based on tag?

@mogoodrich
Copy link
Member Author

Code looks fine but remind me why we need this? Doesn't the core location endpoint allow searching based on tag?

See my comments here from Oct 31st: https://pihemr.atlassian.net/jira/software/c/projects/UHM/boards/54?selectedIssue=UHM-8192

(The recursive nature of the search likely makes it a little clumsy to support using the standard REST Location endpoints.)

@mogoodrich
Copy link
Member Author

Merging, thanks @mseaton !

@mogoodrich mogoodrich merged commit 420306f into master Nov 12, 2024
1 check passed
@mogoodrich mogoodrich deleted the EA-211 branch November 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseaton mseaton mseaton approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mogoodrich @mseaton