Skip to content

Commit

Permalink
RESTWS-799: Overriding methods should do more than simply call the sa…
Browse files Browse the repository at this point in the history
…me method in the super class (#474)
  • Loading branch information
kdaud authored Nov 24, 2020
1 parent 1750317 commit 80ad9c9
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 75 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return d;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return ((ModelImpl) super.getCREATEModel(rep))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,6 @@ public void purge(ConceptClass conceptClass, RequestContext context) throws Resp
Context.getConceptService().purgeConceptClass(conceptClass);
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep);
}

@Override
public Model getUPDATEModel(Representation rep) {
return getCREATEModel(rep);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,6 @@ public Model getGETModel(Representation rep) {
return model;
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep);
}

/**
* @see DelegatingCrudResource#newDelegate()
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return ((ModelImpl) super.getCREATEModel(rep))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ public Model getGETModel(Representation rep) {
return modelImpl;
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep); //FIXME missing props
}

@Override
public Model getUPDATEModel(Representation rep) {
return new ModelImpl(); //FIXME missing props
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return ((ModelImpl) super.getCREATEModel(rep))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return ((ModelImpl) super.getCREATEModel(rep))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@
"1.8.*", "1.9.*", "1.10.*", "1.11.*", "1.12.*", "2.0.*", "2.1.*", "2.2.*", "2.3.*", "2.4.*" })
public class PatientStateResource1_8 extends DelegatingSubResource<PatientState, PatientProgram, ProgramEnrollmentResource1_8> {

@Override
public String getUri(Object instance) {
return super.getUri(instance);
}

@Override
public PatientProgram getParent(PatientState instance) {
return instance.getPatientProgram();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,6 @@ public DelegatingResourceDescription getUpdatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep); //FIXME
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep);
}

@Override
public Model getUPDATEModel(Representation rep) {
return new ModelImpl()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep);
}

@Override
public Model getUPDATEModel(Representation rep) {
return getCREATEModel(rep);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,6 @@ public DelegatingResourceDescription getCreatableProperties() {
return description;
}

@Override
public Model getGETModel(Representation rep) {
return super.getGETModel(rep);
}

@Override
public Model getCREATEModel(Representation rep) {
return super.getCREATEModel(rep);
}

/**
* @see DelegatingCrudResource#newDelegate()
*/
Expand Down

0 comments on commit 80ad9c9

Please sign in to comment.