ci: fix e2e report workflow missing netlify CLI (#2673)

* chore(deps): use netlify-cli dev dep where possible Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :( We were installing it manually in some CI workflows, but not the e2e report one, which started failing. This fixes that by pulling in the easy parts of #2484. * ci: run next.js deps with netlify-cli dev dep
opennextjs · Oct 16, 2024 · 0ce5df5 · 0ce5df5
1 parent 01651dc
commit 0ce5df5
Show file tree

Hide file tree

Showing 8 changed files with 39,796 additions and 12,470 deletions.
diff --git a/.github/workflows/e2e-report.yml b/.github/workflows/e2e-report.yml
@@ -56,4 +56,4 @@ jobs:
       - name: Deploy e2e page
         if: success()
         run: |
-          ntl deploy --build --cwd e2e-report
+          npx netlify deploy --build --cwd e2e-report
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -40,6 +40,7 @@ jobs:
           else
             echo "matrix=[\"latest\"]" >> $GITHUB_OUTPUT
           fi
+
   e2e:
     needs: setup
     runs-on: ubuntu-latest
@@ -68,14 +69,13 @@ jobs:
           deno-version: v1.37.0
       - name: 'Install dependencies'
         run: npm ci
-      - name: 'Netlify Login'
+      - name: 'Prepare Netlify CLI'
         env:
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
         run: |
-          # TODO(serhalp) Unpin version once
-          # https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
-          npm i -g netlify-cli@17.26.0
-          netlify login
+          # Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
+          npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
+          npx netlify login
       - name: Get installed Playwright version
         id: playwright-version
         run: echo "version=$(npm view @playwright/test version)" >> $GITHUB_OUTPUT
@@ -204,14 +204,13 @@ jobs:
         run: npm ci
       - name: 'Build'
         run: npm run build
-      - name: 'Netlify Login'
+      - name: 'Prepare Netlify CLI'
         env:
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
         run: |
-          # TODO(serhalp) Unpin version once
-          # https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
-          npm i -g netlify-cli@17.26.0
-          netlify login
+          # Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
+          npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
+          npx netlify login
       - name: Resolve Next.js version
         id: resolve-next-version
         shell: bash

diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml
@@ -180,8 +180,9 @@ jobs:
         run: npm run build
         working-directory: ${{ env.runtime-path }}
 
-      - name: add netlify cli
-        run: npm install -g netlify-cli
+      - name: Prepare Netlify CLI
+        # Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
+        run: npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
 
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps