Field of Science ID's

[CannonLock]

No description provided.

[osg-bot]

OSG Staff:

There was an unexpected error verifying this PR - please review.

-- OSG-BOT 💥

---

Output from the automerge downtime check script:

Traceback (most recent call last):
  File "/app/webapp/automerge_check.py", line 288, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/app/webapp/automerge_check.py", line 127, in main
    orgs_new   = get_organizations_at_version(head)
  File "/app/webapp/automerge_check.py", line 213, in get_organizations_at_version
    return set( p.get("Organization") for p in projects )
  File "/app/webapp/automerge_check.py", line 213, in <genexpr>
    return set( p.get("Organization") for p in projects )
AttributeError: 'NoneType' object has no attribute 'get'

[matyasselmeci]

You need to quote these new values, especially the field of science IDs which are being interpreted as floating point numbers. Also projects/GRAPLEr.yaml at least is not syntactically correct -- looks like the original file didn't have a newline at the end, so appending stuff broke it.

[CannonLock]

@matyasselmeci I realize this is a brutal review so let me know if you want anything double ( triple ) checked.

Checks I have done:

• Verified all projects have the new keys
• Verified all projects have the same information they previously did ( Downloaded current master and compared all existing keys to those in this PR )

[CannonLock]

Closing in favor of not solving 1100 conflicts -> #3809