Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache and measure the update of the Topology Git repo separately #3907

Merged
merged 5 commits into from
May 29, 2024

Conversation

matyasselmeci
Copy link
Collaborator

instead of having the vo data, projects data, mappings data, and resourcegroup data all pulling from the git repo when they get updated.

While I'm at it, use time.monotonic() instead of time.time() for the cache time (which avoids issues if we run, say, ntpdate).

instead of having the vo data, projects data, mappings data, and resourcegroup data
all pulling from the git repo when they get updated.

While I'm at it, use time.monotonic() instead of time.time() for the cache time
(which avoids issues if we run, say, ntpdate).
@matyasselmeci matyasselmeci marked this pull request as ready for review May 21, 2024 21:20
@matyasselmeci matyasselmeci requested a review from jthiltges May 21, 2024 21:20
Copy link
Collaborator

@jthiltges jthiltges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, aside from time.monotonic

src/webapp/common.py Outdated Show resolved Hide resolved
@matyasselmeci matyasselmeci requested a review from jthiltges May 29, 2024 19:51
Copy link
Collaborator

@jthiltges jthiltges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matyasselmeci matyasselmeci merged commit 09254b2 into opensciencegrid:master May 29, 2024
2 checks passed
@matyasselmeci matyasselmeci deleted the pr/cache-git branch May 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants