Add Storage Page and information to OCP-V section #96

rguske · 2025-01-04T16:17:04Z

The page is providing some high-level but important information for storage in OCP-V . I don't want to create a mirror of our docs but I think it comes in handy having these information quickly available.

Closes: #91

rbo · 2025-01-04T17:04:25Z

/ok-to-test

benito-greybeard-cicd · 2025-01-04T17:05:30Z

💀 There was an error during pre-commit / linter:

An unexpected error has occurred: PermissionError: [Errno 13] Permission denied: '/opt/app-root/src/.cache/pre-commit'

rbo · 2025-01-05T07:42:29Z

@rguske Please rebase your branch, this problem is fixed in 5905be9

rbo · 2025-01-05T12:03:41Z

rebase done

benito-greybeard-cicd · 2025-01-05T12:14:27Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rguske · 2025-01-05T16:22:29Z

LGTM

content/kubevirt/Storage_CSI.png

content/kubevirt/csi-driver-support.png

content/kubevirt/local-storage.md

benito-greybeard-cicd · 2025-01-06T08:47:01Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

benito-greybeard-cicd · 2025-01-06T14:17:47Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rbo · 2025-01-06T19:48:16Z

We should add one topic here, to quota Matthias M.

OCP Virtualization works differently for storage than vSphere and RHV: The reuse of existing storage is the aim by customers across the board but only little is known about the differences in the consumption of storage with OpenShift Virtualization. This reveals to be a major challenge for most of the vSphere to OCP-V projects. In vSphere plain storage consumption, the storage capacity is provided using large volumes (aka described as LUNs) as datastores and then the vmdk "block" devices carved out as files coming from vmfs residing on the datastores. A similar approach is used by RHV. In OCP Virtualization instead, every persistent volume for a virtual disk coming from a block storage must be provided as a real world block storage device. This usually leads to trouble on the OCP nodes as well as on the enterprise storage: the number of PVs used for VMs define the number of block volumes to create on the enterprise storage subsystems, to be handled in SAN mappings, and to be managed by FC/iSCSI and multi-pathing on the OCP nodes.

Source: https://docs.google.com/document/d/1S1ss-GOm97rdGld0NsoZqhDgLiTc5Xhma9sR8K0LLVI/edit?tab=t.0#bookmark=id.szxe3a1g5zj8

What do you think @rguske ?

rguske · 2025-01-07T09:19:06Z

We should add one topic here, to quota Matthias M.

OCP Virtualization works differently for storage than vSphere and RHV: The reuse of existing storage is the aim by customers across the board but only little is known about the differences in the consumption of storage with OpenShift Virtualization. This reveals to be a major challenge for most of the vSphere to OCP-V projects. In vSphere plain storage consumption, the storage capacity is provided using large volumes (aka described as LUNs) as datastores and then the vmdk "block" devices carved out as files coming from vmfs residing on the datastores. A similar approach is used by RHV. In OCP Virtualization instead, every persistent volume for a virtual disk coming from a block storage must be provided as a real world block storage device. This usually leads to trouble on the OCP nodes as well as on the enterprise storage: the number of PVs used for VMs define the number of block volumes to create on the enterprise storage subsystems, to be handled in SAN mappings, and to be managed by FC/iSCSI and multi-pathing on the OCP nodes.

Source: https://docs.google.com/document/d/1S1ss-GOm97rdGld0NsoZqhDgLiTc5Xhma9sR8K0LLVI/edit?tab=t.0#bookmark=id.szxe3a1g5zj8

What do you think @rguske ?

Agree! This is definitely an important information! I'll include it.

rguske · 2025-01-10T09:58:04Z

@rbo I've added the information and highlighted it as important. Please review.

benito-greybeard-cicd · 2025-01-10T10:00:23Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rbo · 2025-01-10T13:54:32Z

@rguske Should we merge it with the https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub/kubevirt/local-storage/ ? To have one Storage and Local Storage as a sub point or included.

rguske · 2025-01-10T15:10:52Z

@rbo local-storage is now merged into storage section. Ready to review.

benito-greybeard-cicd · 2025-01-10T15:14:03Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rbo · 2025-01-10T15:17:45Z

mkdocs.yml

@@ -252,8 +252,8 @@ nav:
      - Descheduler: kubevirt/descheduler/index.md
      - Templates: kubevirt/template.md
      - Ansible: kubevirt/ansible/README.md
-      - Networking: kubevirt/networking/index.md
-      - Local-storage: kubevirt/local-storage.md
+      - Networking: kubevirt/networking.md


It was kubevirt/networking/index.md not kubevirt/networking.md !

rbo · 2025-01-10T15:20:19Z

content/kubevirt/storage.md

+Official documentation: [Configuring local storage for virtual machines
+](https://docs.openshift.com/container-platform/latest/cnv/cnv_virtual_machines/cnv_virtual_disks/cnv-configuring-local-storage-for-vms.html)
+
+## Create a backing directory on each node


Please fix the indenting. It should be

Configuring local storage for virtual machines

Create a backing directory on each node

Create MachineConfig

As it was in the orgiginal one.

Ok the original was not perfect as well:

rbo · 2025-01-10T16:37:25Z

content/kubevirt/storage.md

+## Configuring local storage for virtual machines
+
+Official documentation: [Configuring local storage for virtual machines
+](https://docs.openshift.com/container-platform/latest/cnv/cnv_virtual_machines/cnv_virtual_disks/cnv-configuring-local-storage-for-vms.html)


@rguske #95 - Please fix it as well :-)

Closes: openshift-examples#91 Closes: openshift-examples#95 Signed-off-by: Robert Guske <robert.guske@gmail.com>

rguske · 2025-01-15T14:31:04Z

@rbo Ready for another review.

benito-greybeard-cicd · 2025-01-15T14:35:46Z

💻 Deployed & available at
🌎 https://pr-96-examples-openshift-pub.apps.pumuckl.openshift.pub

rbo · 2025-01-22T14:29:19Z

Thank you!

rbo force-pushed the issue-91 branch from 4382bb6 to 374b7e0 Compare January 5, 2025 12:03

benito-greybeard-cicd bot added the ok-for-test-deployment label Jan 5, 2025

rbo reviewed Jan 5, 2025

View reviewed changes

content/kubevirt/Storage_CSI.png Outdated Show resolved Hide resolved

content/kubevirt/csi-driver-support.png Outdated Show resolved Hide resolved

content/kubevirt/local-storage.md Show resolved Hide resolved

rguske force-pushed the issue-91 branch from 374b7e0 to 8f474be Compare January 6, 2025 08:42

rbo force-pushed the issue-91 branch from 8f474be to 543ab73 Compare January 6, 2025 14:13

rguske force-pushed the issue-91 branch from 543ab73 to b771d7c Compare January 10, 2025 09:55

rguske force-pushed the issue-91 branch from b771d7c to 9285a85 Compare January 10, 2025 15:09

rbo requested changes Jan 10, 2025

View reviewed changes

added storage page to ocpv

73e3ad6

Closes: openshift-examples#91 Closes: openshift-examples#95 Signed-off-by: Robert Guske <robert.guske@gmail.com>

rguske force-pushed the issue-91 branch from 9285a85 to 73e3ad6 Compare January 15, 2025 14:30

rbo merged commit 5392173 into openshift-examples:main Jan 22, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Storage Page and information to OCP-V section #96

Add Storage Page and information to OCP-V section #96

rguske commented Jan 4, 2025

rbo commented Jan 4, 2025

benito-greybeard-cicd bot commented Jan 4, 2025

rbo commented Jan 5, 2025

rbo commented Jan 5, 2025

benito-greybeard-cicd bot commented Jan 5, 2025

rguske commented Jan 5, 2025

benito-greybeard-cicd bot commented Jan 6, 2025

benito-greybeard-cicd bot commented Jan 6, 2025

rbo commented Jan 6, 2025 •

edited

Loading

rguske commented Jan 7, 2025

rguske commented Jan 10, 2025

benito-greybeard-cicd bot commented Jan 10, 2025

rbo commented Jan 10, 2025

rguske commented Jan 10, 2025

benito-greybeard-cicd bot commented Jan 10, 2025

rbo Jan 10, 2025

rguske Jan 15, 2025

rbo Jan 10, 2025

rbo Jan 10, 2025

rbo Jan 10, 2025

rguske Jan 15, 2025

rbo Jan 10, 2025

rguske Jan 15, 2025

rguske commented Jan 15, 2025

benito-greybeard-cicd bot commented Jan 15, 2025

rbo commented Jan 22, 2025

Add Storage Page and information to OCP-V section #96

Add Storage Page and information to OCP-V section #96

Conversation

rguske commented Jan 4, 2025

rbo commented Jan 4, 2025

benito-greybeard-cicd bot commented Jan 4, 2025

rbo commented Jan 5, 2025

rbo commented Jan 5, 2025

benito-greybeard-cicd bot commented Jan 5, 2025

rguske commented Jan 5, 2025

benito-greybeard-cicd bot commented Jan 6, 2025

benito-greybeard-cicd bot commented Jan 6, 2025

rbo commented Jan 6, 2025 • edited Loading

rguske commented Jan 7, 2025

rguske commented Jan 10, 2025

benito-greybeard-cicd bot commented Jan 10, 2025

rbo commented Jan 10, 2025

rguske commented Jan 10, 2025

benito-greybeard-cicd bot commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rguske commented Jan 15, 2025

benito-greybeard-cicd bot commented Jan 15, 2025

rbo commented Jan 22, 2025

rbo commented Jan 6, 2025 •

edited

Loading