Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove config.hypershift check in osde2e test harness #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YiqinZhang
Copy link
Contributor

@YiqinZhang YiqinZhang commented Oct 21, 2024

It’s not necessary for the hypershift check to skip the OSDe2e test.
remove

if viper.GetBool(config.Hypershift) {
	Skip("Certman Operator is not supported on HyperShift")
}

SDCICD-1326

@openshift-ci openshift-ci bot requested review from aliceh and tnierman October 21, 2024 14:41
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YiqinZhang
Once this PR has been reviewed and has the lgtm label, please assign iamkirkbater for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.63%. Comparing base (8ec40aa) to head (42fccb4).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   48.63%   48.63%           
=======================================
  Files          28       28           
  Lines        2093     2093           
=======================================
  Hits         1018     1018           
  Misses        968      968           
  Partials      107      107           

@clcollins
Copy link
Member

/hold

We're pausing new PRs for a little bit while we get the codebase in order

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants