Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HIVE-2687: Privatelink improvements #2528

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jstuever
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@jstuever: This pull request references HIVE-2687 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom December 13, 2024 20:58
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@jstuever jstuever force-pushed the HIVE-2687 branch 2 times, most recently from 97cc525 to 7bd9cd8 Compare December 13, 2024 21:04
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.97207% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.94%. Comparing base (3ccd44d) to head (b90104b).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
pkg/test/logger/logger.go 64.28% 3 Missing and 2 partials ⚠️
...privatelink/actuator/awsactuator/awshubactuator.go 95.50% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2528      +/-   ##
==========================================
+ Coverage   46.26%   49.94%   +3.67%     
==========================================
  Files         279      281       +2     
  Lines       32913    33081     +168     
==========================================
+ Hits        15227    16521    +1294     
+ Misses      16406    15230    -1176     
- Partials     1280     1330      +50     
Files with missing lines Coverage Δ
...rivatelink/actuator/gcpactuator/gcplinkactuator.go 85.67% <100.00%> (+85.67%) ⬆️
...er/privatelink/actuator/mock/actuator_generated.go 100.00% <100.00%> (ø)
...kg/controller/privatelink/conditions/conditions.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/test/clusterdeployment/clusterdeployment.go 100.00% <100.00%> (+2.75%) ⬆️
pkg/test/clusterprovision/clusterprovision.go 97.72% <100.00%> (+0.08%) ⬆️
...privatelink/actuator/awsactuator/awshubactuator.go 91.22% <95.50%> (+91.22%) ⬆️
pkg/test/logger/logger.go 64.28% <64.28%> (ø)

... and 8 files with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@jstuever: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-pool b90104b link true /test e2e-pool
ci/prow/e2e-gcp b90104b link true /test e2e-gcp
ci/prow/e2e b90104b link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants