add :Z mount to fix local validation errors when using podman #193
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RaphaelBut The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I have not tested that this still works with docker |
|
@RaphaelBut: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -61,7 +61,7 @@ yamlList() { | |||
| check_validation() { | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't we add error handling to capture potential errors during execution?
# Ensure the function receives the required parameter
if [ -z "$1" ]; then
echo "Error: No YAML files specified."
return 1
fi
local yaml_files="$1"
|
Hi @RaphaelBut any update for this PR? Is it still needed? |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RaphaelBut - Please rebase the PR to resolve the conflicts. Also, any updates for the PR based on the current review feedback? |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
not sure if this is the right approach but when calling
make validationusing podman I get permissions errors.