Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifest(#2925) #473

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifest(#2925) #473

wants to merge 1 commit into from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Mar 15, 2023 •
edited
Loading

See operator-framework/operator-registry#1069 for more details

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2023
@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See operator-framework/operator-registry#1069 for more details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dinhxuanvu and kevinrizza March 15, 2023 14:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@anik120
Copy link
Contributor Author

anik120 commented Mar 15, 2023

/jira refresh

@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anik120
Copy link
Contributor Author

anik120 commented Mar 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 15, 2023
@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 15, 2023
@anik120 anik120 force-pushed the packegeserver-channel-sort branch 2 times, most recently from fe3dfd9 to 3621838 Compare March 15, 2023 14:20
@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

See operator-framework/operator-registry#1069 for more details

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anik120
Copy link
Contributor Author

anik120 commented Mar 15, 2023

/hold

I don't think I pulled in the commit right, I'll get back to this in a bit

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anik120
Sort channels in lexicographical order in Packagemanifest (#2925)
5936b0f 
See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <anikbhattacharya93@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2
@anik120 anik120 force-pushed the packegeserver-channel-sort branch from 5967c27 to 5936b0f Compare March 15, 2023 17:09
@anik120
Copy link
Contributor Author

anik120 commented Mar 15, 2023

/hold cancel

Should be good now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@tmshort
Copy link
Contributor

tmshort commented Mar 15, 2023 •
edited
Loading

#474 is trying to do a sync from upstream, including this change.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

@anik120: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 5936b0f link true /test verify
ci/prow/e2e-upgrade 5936b0f link true /test e2e-upgrade
ci/prow/unit-olm 5936b0f link true /test unit-olm
ci/prow/e2e-gcp-console-olm 5936b0f link true /test e2e-gcp-console-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anik120 anik120 mentioned this pull request Mar 20, 2023
Closed
@anik120
Copy link
Contributor Author

anik120 commented Mar 20, 2023

#474 (comment)

@anik120 anik120 closed this Mar 20, 2023
@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

See operator-framework/operator-registry#1069 for more details

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anik120 @openshift-ci-robot @tmshort