Fix after_kuttl commands so that the output is not truncated #2675
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commands run after kuttl were simply redirecting the output and not appending to the file, so if there were multiple commmands run, only the output of the last one was kept. Instead, append to the file so the output of all commands is visible.
cescgina
requested review from
pablintino,
lewisdenny,
evallesp,
bshewale and
frenzyfriday
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4fe70a6463414d41a29d65baeb277817 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 18s |
|
recheck |
This was referenced Jan 23, 2025
|
/lgtm thank you @cescgina for fixing it! |
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 23, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from mastter content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers_openstack: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 23, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from mastter content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers_openstack: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 24, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 24, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 24, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 24, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
raukadah
added a commit
to raukadah/watcher-operator
that referenced
this pull request
Jan 24, 2025
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands run after kuttl were simply redirecting the output and not
appending to the file, so if there were multiple commmands run, only the
output of the last one was kept. Instead, append to the file so the
output of all commands is visible.
Depends-On: openstack-k8s-operators/install_yamls#999