Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhol crc/manage secrets #822

Merged
merged 2 commits into from
Nov 29, 2023
Merged

rhol crc/manage secrets #822

merged 2 commits into from
Nov 29, 2023

Conversation

cjeanner
Copy link
Contributor

@cjeanner cjeanner commented Nov 20, 2023 •
edited
Loading

This PR has two distinct patches in it:

  • Removed useless files in manage_secrets
    A tiny change that probably doesn't needs its own pull-request,
    just a small cleaning

  • Switch rhol_crc to the new manage_secrets
    The important part - switching to the new manage_secrets role
    for the sake of consistency and stability.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch from 0e664e4 to e8e2eae Compare November 20, 2023 10:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/27760076f6df4b64944bd8576568cda6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 13m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 59m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-doc SUCCESS in 1m 58s
✔️ cifmw-molecule-manage_secrets SUCCESS in 6m 49s
❌ cifmw-molecule-rhol_crc FAILURE in 11m 26s

@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch 7 times, most recently from f860f6d to 91345c9 Compare November 20, 2023 14:51
@cjeanner
Copy link
Contributor Author

/test all

@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch from 91345c9 to 959bce6 Compare November 27, 2023 16:12
@cjeanner
Copy link
Contributor Author

/test all

@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch 6 times, most recently from d128b36 to a7323df Compare November 27, 2023 18:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #849 is needed.

1 similar comment
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #849 is needed.

@cjeanner
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #849 is needed.

@cjeanner
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #849 is needed.

@cjeanner
Copy link
Contributor Author

recheck

@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch from a7323df to 2692b65 Compare November 28, 2023 08:02
@cjeanner
Copy link
Contributor Author

/test all

@cjeanner cjeanner marked this pull request as ready for review November 28, 2023 08:23
@openshift-ci openshift-ci bot requested review from bshewale and psathyan November 28, 2023 08:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/92c71c4b32e14ca8a694c304025078c3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 18m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 03m 47s
✔️ noop SUCCESS in 0s
❌ cifmw-baremetal-nested-crc FAILURE in 1h 13m 09s
✔️ cifmw-doc SUCCESS in 2m 02s
✔️ cifmw-molecule-manage_secrets SUCCESS in 7m 12s
✔️ cifmw-molecule-rhol_crc SUCCESS in 28m 54s

@cjeanner
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cdff49e762264bfa8bd2c0d0f4d4dbf0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 01m 38s
✔️ noop SUCCESS in 0s
❌ cifmw-baremetal-nested-crc FAILURE in 1h 11m 50s
✔️ cifmw-doc SUCCESS in 2m 22s
✔️ cifmw-molecule-manage_secrets SUCCESS in 7m 14s
✔️ cifmw-molecule-rhol_crc SUCCESS in 25m 51s

@cjeanner
Removed useless files in manage_secrets
2832d54
@cjeanner
Switch rhol_crc to the new manage_secrets
23f9865 
This switch should ensure consistency with the whole pull-secret
management.

It will also ensure we're actually passing down the needed bits to the
deploy and throw an early failure if needed.

We also take the opportunity to remove the useless `run:` parameter from
the job definition, while adding the needed parameter.
@cjeanner cjeanner force-pushed the rhol_crc/manage_secrets branch from 2692b65 to 23f9865 Compare November 28, 2023 11:49
marios
marios approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right/didn't spot something

ci_framework/roles/rhol_crc/README.md
role, you **must** provide either `cifmw_manage_secrets_pullsecret_file` OR
`cifmw_manage_secrets_pullsecret_content`.

If you provide neither, it will fail. If you provide both, it will also fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you provide neither, or both, it will fail.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on this one

@openshift-ci openshift-ci bot added the lgtm label Nov 29, 2023
@pablintino
Copy link
Collaborator

/approve

Update the small English nit on a PR if you want

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3c68e8c into main Nov 29, 2023
2 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the rhol_crc/manage_secrets branch November 29, 2023 12:32
@marios marios mentioned this pull request Nov 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino pablintino left review comments

@marios marios marios approved these changes

@bshewale bshewale Awaiting requested review from bshewale bshewale is a code owner

@psathyan psathyan Awaiting requested review from psathyan

Assignees

@marios marios

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjeanner @pablintino @marios