Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completeRelations option to pgsnapshot dataset bounding box filter #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreynovikov
Copy link

No description provided.

@brettch
Copy link
Member

brettch commented Oct 30, 2016

Hi @andreynovikov, it looks like the Travis build is failing for your pull request. Can you please take a look and fix any issues? It looks like it's just a checkstyle problem. You can see the travis logs by clicking the "Details" link next to the failed build above.

@brettch
Copy link
Member

brettch commented May 19, 2020

This PR seems like a good idea. I believe the failing build was the only thing blocking it from being merged previously. I'm always cautious about making changes to pgsnapshot because little changes can have major performance implications, however this change adds an optional feature that is disabled by default.

It will also require some documentation updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants