Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package]: migrate ErrorBoundary component to TypeScript #446

Conversation

raskolnikov-rodion
Copy link
Contributor

@raskolnikov-rodion raskolnikov-rodion commented Aug 25, 2024

Description

Migrate the ErrorBoundary component to TypeScript.

Issue: opentargets/issues#2871

Type of change

  • TypeScript refactor

How Has This Been Tested?

Applications were built locally. Component was imported into StudiesPage from ui and manually inspected in the UI.

Condition: No error
image

Condition: With error, community view
image

Condition: With error, partner view
image

Condition: With error, dummy error message
image

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chinmehta chinmehta added the community Open source contributions from community label Aug 27, 2024
@raskolnikov-rodion raskolnikov-rodion force-pushed the refactor/error-boundary-ts branch from d2b779b to d0f4402 Compare November 10, 2024 10:27
@carcruz
Copy link
Contributor

carcruz commented Jan 15, 2025

At the moment, we have open work related to the ErrorBoundary component. Will close this one as duplicate

@carcruz carcruz closed this Jan 15, 2025
@raskolnikov-rodion raskolnikov-rodion deleted the refactor/error-boundary-ts branch January 27, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Open source contributions from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants