Lazily initialize tracer for Jaeger/1.10 compatibility #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running The Jaeger Python Client with this library, the initialization step hangs indefinitely with Django 1.10.
@mikebryant if you take your example OpenTracing/Jaeger Django project and upgrade Django to >=1.10 and try running, the server will fail to start.
I believe this comes down to the way in which Django changed the initialization of Middleware. In versions prior to Django 1.10, the middleware wouldnt be initialized until the first request. In Django 1.10+, the middleware is initialized on start. Initializing the Jaeger tracer before the first request causes the Jaeger client to deadlock -- check out Jaeger Issue 31 and Jaeger Issue 60.
This change simply forces the initialization to happen once on the first request, thus avoiding the above behavior.