-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliding Window Allreduce Stubs #902
Sliding Window Allreduce Stubs #902
Conversation
Can one of the admins verify this patch? |
4772b81
to
0c58ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix exposing internal structs, then should be good to go
e814a16
to
fcdacf3
Compare
fcdacf3
to
06fc8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, it looks good to me. I only left minor comments mostly on the tests
ba703a0
to
7f44345
Compare
Hi @samnordmann , I have updated the review with your comments. |
7f44345
to
0984efa
Compare
I'm seeing that many comments are not addressed. Also, the CI needs to be green. Please, can you re-request for review through github when it is ready ? |
229b6ba
to
358f022
Compare
ddc2eb1
to
748c552
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5f50edf
to
88877f8
Compare
@Sergei-Lebedev whenever you get a chance, could you review? |
6d57dc1
to
60570b9
Compare
60570b9
to
d79080d
Compare
@Sergei-Lebedev we've removed the ep array ptr, in the follow up we'll just us a macro for a cleaner implementation, but we're going to rely on the hash look up (if it comes back to be less performant, we can make the change then and provide data). Whenever you can, please give it a quick look - I'm very eager to get this in so we can open up follow up |
d79080d
to
c872b8d
Compare
Thanks, LGTM, please fix few minor comments |
c872b8d
to
7007c7b
Compare
7007c7b
to
af4ec63
Compare
This PR (1 out of 2 PRs) defines the structs and function stubs for sliding window allreduce. It also adds a gtest for the algorithm. The next PR will have the function implementations.
@janjust @manjugv @samnordmann @Sergei-Lebedev