TOPO: fix rank reordering for host ordered sbgp #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
force-pushed
the
topic/fix_rank_reordering
branch
from
061286f to
c16f2bd
Compare
samnordmann
approved these changes
Jan 25, 2024
|
bot:retest |
Sergei-Lebedev
force-pushed
the
topic/fix_rank_reordering
branch
from
dcc7dcd to
21c0404
Compare
bureddy
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add check if reordering is required before computing it.
Why ?
Previous version of rank reordering algorithm is based on host hash, socket id and numa id. This algorithm can't detect if reordering is required and sometimes might generate permutation that mixes nodes but not ranks within node. Even though such permutation is equivalent to "no ordering" it still disables some algorithms (e.g. neighbor exchange allgather).