UTIL: fix memory barrier for aarch64 #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
approved these changes
Mar 6, 2024
janjust
approved these changes
Mar 6, 2024
|
@bureddy Hey Deva, can you take a quick look - super small patch, but fixes a critical issue on GH systems. |
bureddy
approved these changes
Mar 14, 2024
Sergei-Lebedev
force-pushed
the
topic/fix_membarrier_aarch64
branch
from
a5bb97a to
72ec5d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes memory barrier in TL SHM.
Why ?
dmb guarantees only ordering, with dsb we correctly wait for store to finish before signaling