Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL/MLX5: fix team init error handling flow #953

Merged
merged 2 commits into from
Apr 11, 2024
Merged

TL/MLX5: fix team init error handling flow #953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f7480
TL/MLX5: fix team init error handling flow
samnordmann Apr 4, 2024
4f44fef
Merge branch 'master' into tl_mlx5/fix_a2a_error_handling_during_team…
samnordmann Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/tl/mlx5/tl_mlx5_team.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,18 @@ static inline ucc_status_t ucc_tl_mlx5_a2a_team_test(ucc_base_team_t *team)
if (UCC_OK != tl_team->a2a_status.local) {
tl_debug(UCC_TL_TEAM_LIB(tl_team), "failed to init a2a: %s",
ucc_status_string(tl_team->a2a_status.local));
tl_team->a2a_state = TL_MLX5_TEAM_STATE_ALLTOALL_NOT_AVAILABLE;
} else {
tl_team->a2a_state = TL_MLX5_TEAM_STATE_ALLTOALL_READY;
tl_debug(UCC_TL_TEAM_LIB(tl_team), "initialized tl a2a team: %p",
tl_team);
}
tl_team->a2a_state = TL_MLX5_TEAM_STATE_ALLTOALL_READY;
tl_debug(team->context->lib, "initialized tl a2a team: %p", tl_team);
case TL_MLX5_TEAM_STATE_ALLTOALL_READY:
case TL_MLX5_TEAM_STATE_ALLTOALL_NOT_AVAILABLE:
return UCC_OK;
default:
tl_error(team->context->lib, "unknown state during a2a team: %p create", tl_team);
tl_error(UCC_TL_TEAM_LIB(tl_team),
"unknown state during a2a team: %p create", tl_team);
return UCC_ERR_NO_RESOURCE;
}
}
Expand Down
Loading