TL/MLX5: fix warning and var names #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MamziB
requested review from
samnordmann,
janjust and
Sergei-Lebedev
and removed request for
samnordmann
MamziB
force-pushed
the
mamzi/mcast-merge-15
branch
from
9cabf5c to
e63f93b
Compare
samnordmann
reviewed
Apr 19, 2024
MamziB
force-pushed
the
mamzi/mcast-merge-15
branch
from
e63f93b to
1c2c964
Compare
|
Hi @samnordmann Thanks for the comments, I have addressed all of them in the new commit. Can you please take a look and press the Resolve button yourself? |
samnordmann
approved these changes
Apr 19, 2024
|
@samnordmann oh sorry, I re-requested to review by mistake. |
samnordmann
approved these changes
Apr 22, 2024
Sergei-Lebedev
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL/MLX5: fix warning and var names
checking if the mcast ctx is created, then we attempt to create the mcast team to avoid warning + some of the variable names got enhanced