Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL/UCP: add reduce scatter knomial #970

Merged
merged 3 commits into from
May 30, 2024
Merged

TL/UCP: add reduce scatter knomial #970

merged 3 commits into from
May 30, 2024

Conversation

Sergei-Lebedev
Copy link
Contributor

What

Add reduce scatter knomial algorithm in TL/UCP

Performance:
8 nodes 64 ppn

msgsize: knomia us. ring us.
4 29.45 271.84
8 43.29 792.63
16 53.09 950.44
32 60.85 763.14
64 123.39 883.84
128 531.5 974.35
256 1026.58 1075.77
512 1028.21 1042.87
1024 1942.62 1331.72
2048 2149.71 1287.28
4096 4126.88 2087.69
8192 8338.22 3880.91

8 nodes 1 ppn

msgsize: knomial us. ring us.
4 5.47 11.59
8 5.56 14.15
16 4.69 13.96
32 4.83 13.92
64 5.34 14.36
128 5.52 15.37
256 6.16 15.88
512 7.43 19.06
1024 8.14 19.8
2048 9.48 21.71
4096 11.8 25.79
8192 18.59 30.37
16384 26.32 38.85
32768 47.18 58.44
65536 79.68 109.75
131072 130.79 171.54

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/tl_ucp_rs_knomial branch 2 times, most recently from b003661 to 2f1e52f Compare May 3, 2024 12:25
@Sergei-Lebedev Sergei-Lebedev requested a review from samnordmann May 7, 2024 09:45
samnordmann
samnordmann approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@samnordmann samnordmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only left minor comments

test/gtest/coll/test_reduce_scatter.cc Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Outdated Show resolved Hide resolved
src/components/tl/ucp/reduce_scatter/reduce_scatter_knomial.c Show resolved Hide resolved
@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/tl_ucp_rs_knomial branch 2 times, most recently from 5ae518a to cfb22b8 Compare May 17, 2024 07:03
@janjust
Copy link
Collaborator

janjust commented May 29, 2024

@manjugv we need one of you guys to sign off review, @Sergei-Lebedev needs a review from someone else other than himself

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/tl_ucp_rs_knomial branch from cfb22b8 to 878f241 Compare May 30, 2024 05:42
@Sergei-Lebedev Sergei-Lebedev merged commit b62b472 into openucx:master May 30, 2024
8 of 11 checks passed
@Sergei-Lebedev Sergei-Lebedev deleted the topic/tl_ucp_rs_knomial branch May 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samnordmann samnordmann samnordmann approved these changes

@bureddy bureddy bureddy approved these changes

@manjugv manjugv manjugv approved these changes

Assignees
No one assigned
Labels
Ready-for-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sergei-Lebedev @janjust @manjugv @bureddy @samnordmann