TL/NCCL: disable active set colls for lazyinit #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
approved these changes
May 6, 2024
manjugv
approved these changes
May 9, 2024
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_disable_active_set_lazy_init
branch
from
211f727 to
4b70a2d
Compare
nsarka
approved these changes
May 10, 2024
bureddy
approved these changes
May 13, 2024
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_disable_active_set_lazy_init
branch
from
4b70a2d to
52c73a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Disable active set bcast in TL NCCL when lazy communicator init is used
Why ?
With lazy init we cannot create communicator on first collective since not all ranks participate in init