-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/MLX5: one-sided mcast reliability init #980
Conversation
fc9aed7
to
fad5590
Compare
bot:retest |
1 similar comment
bot:retest |
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_reliability.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide more context and explanation about the PR? It is a big PR so it is challenging to review without context and walkthrough.
I see different new options in ucc_tl_mlx5_mcast_coll_comm_init_spec_t
, like enable_truly_zero_copy_pipelined_allgather
, one_sided_reliability_enabled
. Can you explain what is the role of them and why they cannot be treated in different PRs?
Also, can you add tests for those new features?
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_reliability.c
Outdated
Show resolved
Hide resolved
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_reliability.c
Outdated
Show resolved
Hide resolved
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_reliability.c
Outdated
Show resolved
Hide resolved
fad5590
to
a2798fd
Compare
@nsarka @janjust @samnordmann Thanks everyone for the constructive comments. I have pushed all the requested changes. Please take a look and feel free to hit the resolve button if they look good. |
a2798fd
to
e1be369
Compare
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_reliability.c
Outdated
Show resolved
Hide resolved
@samnordmann These options are for algo selection and check if one-sided is enabled. Let me remove the options that are not necessary for this PR. |
@samnordmann Thanks for the comments. I added a new commit (a separate commit) with all the new requested changes. It will be easier this way to track what has changed, at the end I will squash all the commits into a single one. |
6598665
to
b8280d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for addressing my comments
b8280d1
to
c71f4cf
Compare
@Sergei-Lebedev Thanks Sergey for the comments. I have resolved all of them. |
@MamziB pls rebase |
c71f4cf
to
ae5f6f8
Compare
@Sergei-Lebedev Thanks for the comments, I have rebased it on top of latest master. |
TL/MLX5: one-sided mcast reliability init that will be used for mcast-based allgather