Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL/SHARP: check comm size in sharp ctx create #990

Merged

Conversation

Sergei-Lebedev
Copy link
Contributor

What

Don't create sharp ctx if world size is less than 2

Why ?

fixes

==== backtrace (tid:   1051) ====
0 0x0000000000042520 __sigaction()  ???:0
1 0x0000000000025562 ucc_sbgp_create()  /build-result/src/hpcx-v2.19-gcc-mlnx_ofed-redhat7-cuda12-x86_64/ucc-0b4a0780918900fa497b1e6a65485247fecec4a2/src/components/topo/ucc_sbgp.c:599
2 0x0000000000024c95 ucc_topo_get_sbgp()  /build-result/src/hpcx-v2.19-gcc-mlnx_ofed-redhat7-cuda12-x86_64/ucc-0b4a0780918900fa497b1e6a65485247fecec4a2/src/components/topo/ucc_topo.c:224
3 0x0000000000004ce2 ucc_tl_sharp_context_init()  /build-result/src/hpcx-v2.19-gcc-mlnx_ofed-redhat7-cuda12-x86_64/ucc-0b4a0780918900fa497b1e6a65485247fecec4a2/src/components/tl/sharp/tl_sharp_context.c:294
4 0x0000000000005158 ucc_tl_sharp_context_create_epilog()  /build-result/src/hpcx-v2.19-gcc-mlnx_ofed-redhat7-cuda12-x86_64/ucc-0b4a0780918900fa497b1e6a65485247fecec4a2/src/components/tl/sharp/tl_sharp_context.c:443
5 0x000000000000d597 ucc_context_create_proc_info()  /build-result/src/hpcx-v2.19-gcc-mlnx_ofed-redhat7-cuda12-x86_64/ucc-0b4a0780918900fa497b1e6a65485247fecec4a2/src/core/ucc_context.c:808
6 0x0000000000098bd2 ucc::context_wrapper::context_wrapper()  ???:0

@Sergei-Lebedev Sergei-Lebedev merged commit a360c7a into openucx:master Jun 24, 2024
10 of 11 checks passed
@Sergei-Lebedev Sergei-Lebedev deleted the topic/tl_sharp_check_team_size branch June 24, 2024 17:02
MamziB pushed a commit to MamziB/ucc-forked that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants