Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial autotools infrastructure #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

evgeny-leksikov
Copy link

@yosefe pls take a look

@evgeny-leksikov
Copy link
Author

@alex-mikheev pls take a look

@mike-dubman
Copy link

+1
please add contrib/test_jenkins.sh with basic test sequence like build w/ gcc, run gtest
Michael will add jenkins support for it.

Copy link

@alex-mikheev alex-mikheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho copyright on new files should start from the current year (2017-)

@mike-dubman
Copy link

@MrBr-github, @Di0gen - please note test_jenkins.sh

@mike-dubman
Copy link

+1

mkdir -p $GTEST_REPORT_DIR

echo "==== Running unit tests ===="
$AFFINITY $TIMEOUT make -C test gtest_ucxprotobuf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environments $AFFINITY $TIMEOUT are not defined in the script.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shamisp
Copy link

shamisp commented Oct 31, 2017

@miked-mellanox @yosefe we have to define maintainers for this project.

@mike-dubman
Copy link

@evgeny-leksikov just volunteered

@evgeny-leksikov
Copy link
Author

I have no objections :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants