-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial autotools infrastructure #1
base: master
Are you sure you want to change the base?
Conversation
@alex-mikheev pls take a look |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho copyright on new files should start from the current year (2017-)
@MrBr-github, @Di0gen - please note test_jenkins.sh |
+1 |
mkdir -p $GTEST_REPORT_DIR | ||
|
||
echo "==== Running unit tests ====" | ||
$AFFINITY $TIMEOUT make -C test gtest_ucxprotobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environments $AFFINITY $TIMEOUT are not defined in the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@miked-mellanox @yosefe we have to define maintainers for this project. |
@evgeny-leksikov just volunteered |
I have no objections :) |
@yosefe pls take a look