Compilation fixed for kernel 5.10.x #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Margolin <alex.margolin@huawei.com>
shamisp
requested changes
Dec 28, 2020
| @@ -17,7 +17,6 @@ | |||
| #include <linux/cdev.h> | |||
| #include <linux/percpu.h> | |||
|
|
|||
| #include <asm/tlb.h> | |||
There was a problem hiding this comment.
@alex--m you have to ifdef this include for versions below 5.10.x. For an example grep for LINUX_VERSION_CODE in the code
|
@alex--m I'm running 5.10.6-200.fc33.aarch64 and I don't see this compilation issue. |
|
related to hpc#48 |
|
@yosefe I don't have any x86 to test. If you confirm it works, I will merge, |
|
@yosefe also, probably should be wrapped with LINUX_VERSION_CODE |
|
I tested building with kernel 5.0 and older stable branches. 4.9 and below fail to build anyway. 4.14 and above work fine with the fix. |
|
Also, as I noted in #43, for me the build fails starting from kernel 5.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Margolin alex.margolin@huawei.com