Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whisper pipeline: use Sampler #1615
base: master
Are you sure you want to change the base?
Whisper pipeline: use Sampler #1615
Changes from 25 commits
68d3e48
ade7313
b2df4a6
17e3ea7
806b01a
e041a33
9502d9b
6c30fa4
7600072
f870a4c
e38cf5c
acc656f
aa0f742
3728884
445ce5a
5bdd695
7f2a153
c368401
2e061aa
4eaa9a7
3139a43
50fb829
5021742
04318d1
9e08d18
56bf11c
50eb509
e802584
abde309
3348ad5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sequence group knows about its generation parameters, maybe we can add a new method for sequence group
get_max_new_tokens()
, which will handle max_new_tokens internally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sampler::GroupBeamSearcher::Group
holdsBeams
Beam
holds itsSequence
Sequence
has a pointer to containingSequenceGroup
SequenceGroup
will haveget_max_new_tokens
methodLooks like we can drop all arguments from this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, maybe we can perform such changes as a separate (follow-up) PR?
in other places we also have max_new_tokens which should be replaced new your solution.