Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lissi Entries #118

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Update Lissi Entries #118

merged 3 commits into from
Oct 25, 2024

Conversation

ed-curran
Copy link
Contributor

@ed-curran ed-curran commented Oct 17, 2024

Hi, I'm a developer at Lissi.

We added some more complete information for the Lissi entries (wallet and eudi wallet connector.

Wasn't quite sure how logo works. If its a file or URL. Let me know if this isn't correct.

Signed-off-by: or <edward.curran@lissi.id>
@cre8
Copy link
Contributor

cre8 commented Oct 19, 2024

Hi, I'm a developer at Lissi.

We added some more complete information for the Lissi entries (wallet and eudi wallet connector.

Wasn't quite sure how logo works. If its a file or URL. Let me know if this isn't correct.

The preferred way is to store it as a file in case the logo is not available via the link anymore. Logos are stored in https://github.com/openwallet-foundation/digital-wallet-and-agent-overviews-sig/tree/main/viewer%2Fsrc%2Fassets%2Flogos

Let me know if you want to update it or if it's fine to be pushed

Signed-off-by: or <edward.curran@lissi.id>
@ed-curran
Copy link
Contributor Author

@cre8 I updated the logo file. When i run npm start i get an error

Application bundle generation failed. [2.033 seconds]

✘ [ERROR] TS2353: Object literal may only specify known properties, and '"lockfileVersion"' does not exist in type 'Wallet'. [plugin angular-compiler]

    src/app/wallets/wallets-data.ts:1361:4:
      1361 │     "lockfileVersion": 3,
           ╵     ~~~~~~~~~~~~~~~~~

not sure if i'm meant to push the changes to wallets-data.ts

@cre8
Copy link
Contributor

cre8 commented Oct 25, 2024

@cre8 I updated the logo file. When i run npm start i get an error

Application bundle generation failed. [2.033 seconds]

✘ [ERROR] TS2353: Object literal may only specify known properties, and '"lockfileVersion"' does not exist in type 'Wallet'. [plugin angular-compiler]

    src/app/wallets/wallets-data.ts:1361:4:
      1361 │     "lockfileVersion": 3,
           ╵     ~~~~~~~~~~~~~~~~~

not sure if i'm meant to push the changes to wallets-data.ts

Wallet data is auto generated before the app starts. So you only need to update the Json files

@ed-curran
Copy link
Contributor Author

should be fine for it to be pushed then

wallets/lissi-wallet.json Outdated Show resolved Hide resolved
wallets/lissi-eudi-wallet-connector.json Outdated Show resolved Hide resolved
Signed-off-by: or <edward.curran@lissi.id>
@cre8 cre8 merged commit cb90cc5 into openwallet-foundation:main Oct 25, 2024
6 checks passed
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 26, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 pushed a commit to cre8/digital-wallet-and-agent-overviews-sig that referenced this pull request Oct 28, 2024
* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
cre8 added a commit that referenced this pull request Oct 28, 2024
* migrate credential profile content to this repo

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* improve scripts

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* fix linting

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* move files to data folder

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* rename files

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* move files

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* Update Lissi Entries (#118)

* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* fix validation

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* Update Lissi Entries (#118)

* update lissi entries

Signed-off-by: or <edward.curran@lissi.id>

* update lissi logo

Signed-off-by: or <edward.curran@lissi.id>

* fix logo reference

Signed-off-by: or <edward.curran@lissi.id>

---------

Signed-off-by: or <edward.curran@lissi.id>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* fix structure of schemas and files

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* tmp fix

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* undo

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* add resources based on profile

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* optimize filter for wallet list

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

* move wallets in new structure

Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>

---------

Signed-off-by: Mirko Mollik <mirko.molliksprind.org>
Signed-off-by: Mirko Mollik <mirkomollik@gmail.com>
Signed-off-by: or <edward.curran@lissi.id>
Co-authored-by: Mirko Mollik <mirko.molliksprind.org>
Co-authored-by: Edward Curran <edward.curran@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants