Fix maketext
interpolation in PG.
#2213
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key to making this work is to override the
_compile
method ofLocale::Maketext
and remove theuse strict
usage inside of its code eval call. That is the only essential difference between the override method added here and the orignal method inLocale::Maketext
.With this you can now use maketext interpolation in PG. For example, you can call
maketext('[quant,_1,dog] ate my homework', $num_dogs)
.This is an important part of removing the attempts table, and moving the code the provides feedback to PG.
The WeBWorK::Localize module is also cleaned up considerably.