Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Django 3.2 support #313

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Remove Django 3.2 support #313

merged 3 commits into from
Nov 2, 2024

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Oct 31, 2024 •
edited
Loading

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #312

Description of Changes

  • Removes any compatibility code or doc for <4.2 versions of Django
  • Remove 3.2 from CI and docs
  • Modernize the code for Django 4.2 with the help of django-upgrade

pauloxnet
pauloxnet approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulgens
Copy link
Contributor Author

ulgens commented Oct 31, 2024

@pauloxnet May I get an approval for the checks, please 🌷

@pauloxnet
Copy link
Contributor

I already approved it. But maybe you need an administrator to approve it

@ulgens ulgens mentioned this pull request Oct 31, 2024
Closed
nemesifier
nemesifier reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is running.

nemesifier
nemesifier requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulgens can you please run openwisp-qa-format and commit the changes?

@ulgens
Copy link
Contributor Author

ulgens commented Nov 2, 2024

@nemesifier
CleanShot 2024-11-02 at 11 55 40@2x

Should be okay now, may I get another approval for the checks please?

@ulgens ulgens requested a review from nemesifier November 2, 2024 09:09
@nemesifier
Copy link
Member

Thanks 🙏

@nemesifier nemesifier merged commit 529e449 into openwisp:master Nov 2, 2024
1 of 9 checks passed
@ulgens ulgens deleted the remove_django32 branch November 2, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Django 3.2 support
3 participants
@ulgens @pauloxnet @nemesifier