[change] Made get_one_time_login_url utility function #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Jan 9, 2024
openwisp_radius/tests/test_utils.py
Outdated
|
|
||
| @override_settings(AUTHENTICATION_BACKENDS=[]) | ||
| def test_get_one_time_login_url(self): | ||
| get_one_time_login_url(None, None) |
There was a problem hiding this comment.
what is this test doing? Why there's isn't even one assertion here?
There was a problem hiding this comment.
This test was ensuring that the function runs without any error is sesame backend is not present in the AUTHENTICATION_BACKENDS . I will add an assertion here.
pandafy
force-pushed
the
get-one-time-login-url
branch
from
0fb2e61 to
d32fe55
Compare
nemesifier
approved these changes
Jan 10, 2024
nemesifier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.