Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying reencode's tmp dir #230

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Allow specifying reencode's tmp dir #230

merged 1 commit into from
Jan 6, 2025

Conversation

benoit74
Copy link
Collaborator

Fix #162

@benoit74 benoit74 self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (562c997) to head (92cb99e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2455      2456    +1     
  Branches       331       331           
=========================================
+ Hits          2455      2456    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 changed the title All specifying reencode's tmp dir Allow specifying reencode's tmp dir Dec 20, 2024
@benoit74 benoit74 force-pushed the strict_mode branch 5 times, most recently from 76e5157 to e84189c Compare December 20, 2024 09:05
src/zimscraperlib/video/encoding.py Outdated Show resolved Hide resolved
@benoit74 benoit74 marked this pull request as ready for review December 20, 2024 09:16
Base automatically changed from strict_mode to main January 6, 2025 13:01
@benoit74 benoit74 merged commit db251ee into main Jan 6, 2025
3 checks passed
@benoit74 benoit74 deleted the reencode_tmp_file branch January 6, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow specifying reencode's tmp dir
2 participants