Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple CI workflow improvements #382

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Nov 1, 2023

  • Use latest version of kiwix-build CI images
  • Add macos12 and macos13 to CI
  • Use latest version of actions/setup-python and Python 3.9 (in place of 3.7) for macOS

@kelson42 kelson42 added this to the 3.3.0 milestone Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66371fa) 27.49% compared to head (a32caad) 27.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   27.49%   27.49%           
=======================================
  Files          26       26           
  Lines        2550     2550           
  Branches     1356     1356           
=======================================
  Hits          701      701           
  Misses       1368     1368           
  Partials      481      481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 changed the title Use latest version of kiwix-build CI image Multiple CI workflow improvements Nov 1, 2023
@kelson42 kelson42 force-pushed the multiple-ci-small-improvements branch from db195ce to 81c7fc9 Compare November 1, 2023 12:38
@kelson42 kelson42 marked this pull request as ready for review November 1, 2023 12:39
@kelson42 kelson42 requested a review from mgautierfr November 1, 2023 12:39
@kelson42
Copy link
Contributor Author

kelson42 commented Nov 1, 2023

@mgautierfr I don't get why it does not compile on macos12 and macos13. Do you? Why?

@mgautierfr
Copy link
Collaborator

We were using the deprecated osx name for the platform. This is now fixed.
(And I also removed theses archives from the server)

@mgautierfr mgautierfr merged commit b8a0a4c into main Nov 7, 2023
13 checks passed
@mgautierfr mgautierfr deleted the multiple-ci-small-improvements branch November 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants