-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modules to support k8s v0.29.2 #319
Update modules to support k8s v0.29.2 #319
Conversation
Add support for kubernetes v0.29.2 in the Operator Framework api project dependencies. Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Updated controller tools to v0.14.0. Refreshed auto-generated files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 42.45% 42.45%
=======================================
Files 42 42
Lines 4011 4011
=======================================
Hits 1703 1703
Misses 2156 2156
Partials 152 152 ☔ View full report in Codecov by Sentry. |
@joelanford could you review this PR? Needs an approval for the workflows to run |
@everettraven @gallettilance can you help with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Neo2308 looks like this is failing a CI check |
@everettraven I think it should be fixed now, need approval to run the tests again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@gallettilance @joelanford @kevinrizza the checks have passed now, could you review? cc: @everettraven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. I'm going to hold off on merging on a go ahead from @grokspawn and/or @tmshort as they have been orchestrating quite a few dependency bumps over the past few days across various operator-framework projects.
I just spoke with @grokspawn and @tmshort in our community slack channel, and the consensus was that they would like to hold dependency bump PRs until they have a chance to take a look and can help orchestrate it amongst the many other dependabot and other bumps they have been doing. They mentioned likely not having cycles to take a look until next week at the earliest. Apologies for the delay, and many thanks for your understanding @Neo2308 ! |
I'm going to look to see how bad this looks for OLM... |
/approve We're ready to coordinate OLMv0 repos' k8s bumps, now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn, Neo2308 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11a4de6
into
operator-framework:master
Add support for kubernetes v0.29.2 in the Operator Framework/api project dependencies.
Includes changes from #313
Helps with operator-framework/operator-sdk#6651