Fix CRD-Generator tests and examples #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Bernhard Strähle <bernhard.straehle@gmail.com>
baloo42
force-pushed
the
fix/fabric8-7-crd-generator-examples
branch
from
baca27b to
5c1b637
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
reviewed
Nov 30, 2024
| @@ -43,7 +43,7 @@ void correctlyAppliesManuallySpecifiedCRD() { | |||
| @Group("crd.example") | |||
| @Version("v1") | |||
| @Kind("Test") | |||
| private static class TestCR extends CustomResource<Void, Void> implements Namespaced { | |||
| public static class TestCR extends CustomResource<Void, Void> implements Namespaced { | |||
There was a problem hiding this comment.
Is this change necessary? I think we used different visibility on purpose to check if this was possible to do…
There was a problem hiding this comment.
I'm currently looking into this. It was somehow necessary in this project to get it working on my machine.
It's possible that this is a not yet known "breaking" change.
There was a problem hiding this comment.
Found the root cause here https://github.com/fabric8io/kubernetes-client/blob/main/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/CustomResourceInfo.java#L168
getDeclaredConstructor() does only work with public classes.
metacosm
reviewed
Nov 30, 2024
| @@ -7,5 +7,5 @@ | |||
|
|
|||
| @Group("sample.javaoperatorsdk") | |||
| @Version("v1") | |||
| class TestCustomResource extends CustomResource<Void, Void> implements Namespaced { | |||
| public class TestCustomResource extends CustomResource<Void, Void> implements Namespaced { | |||
metacosm
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CRD-Generator tests and examples for #2540
See also fabric8io/kubernetes-client#6683
/cc @metacosm