Use resource pattern resolver to look up CRDs from classpath #196
Conversation
|
|
||
| private Resource[] findResources() { | ||
| final var resourceResolver = new PathMatchingResourcePatternResolver(); | ||
| final var resourceLocationPattern = crdPath + '*' + crdSuffix; |
There was a problem hiding this comment.
Users may find it more useful if they can specify the entire location pattern or even a set of patterns (e.g., META-INF/fabric8/*-v1.yml and META-INF/fabric8/*-v2.yml). This is a breaking change and outside the scope of the fix, so let me leave it for now.
|
Hi @ajalab thank you for PR, could you pls format the code, simply by running thank you! |
|
Thanks! |
|
Umm, according to the test result, there is something wrong in the CRD registration in some tests. Let me work on the fix and let you know after finishing it. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
It turned out that the test was failed because the previous path concatenation could not handle |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
thank you! |
fixes #195.
This PR updates
DefaultCRDApplierto usePathMatchingResourcePatternResolverto look up CRD manifests from Java classpath resources in arbitrary formats, including JARs pulled from a dependency.