Skip to content

Commit

Permalink
chore: doc comment the need to keep using blang for version ranges (#…
Browse files Browse the repository at this point in the history
…1600)

Co-authored-by: Artur Zych <5843875+azych@users.noreply.github.com>
  • Loading branch information
azych and azych authored Jan 15, 2025
1 parent baecd3b commit bb018c3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/catalogmetadata/filter/successors.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ func legacySuccessor(installedBundle ocv1.BundleMetadata, channels ...declcfg.Ch
}
}
if candidateBundleEntry.SkipRange != "" {
// There are differences between how "github.com/blang/semver/v4" and "github.com/Masterminds/semver/v3"
// handle version ranges. OLM v0 used blang and there might still be registry+v1 bundles that rely
// on those specific differences. Because OLM v1 supports registry+v1 bundles,
// blang needs to be kept alongside any other semver lib for range handling.
// see: https://github.com/operator-framework/operator-controller/pull/1565#issuecomment-2586455768
skipRange, err := bsemver.ParseRange(candidateBundleEntry.SkipRange)
if err == nil && skipRange(installedBundleVersion) {
return true
Expand Down

0 comments on commit bb018c3

Please sign in to comment.