✨ Use a separate namespace for each e2e test #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 42 42
Lines 3063 3063
=======================================
Hits 2244 2244
Misses 644 644
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I have encountered one failure over the course of several dozen; so this is not perfect, but it does reduce the likelyhood |
tmshort
force-pushed
the
fix-e2e-flakes
branch
3 times, most recently
from
d940463 to
7b79ace
Compare
|
Of course, it failed e2e... but it failed because the bundle's CRDs were still present... not much we can do here except chase a timeout, which is never a good idea. This was the interesting condition on the CRDs: |
tmshort
force-pushed
the
fix-e2e-flakes
branch
from
7b79ace to
2927437
Compare
Fixes operator-framework#1307 Create and use a new namespace for every e2e test. This means that extension resources are placed in their own namespace. The tests deletes the namespace, and then waits until completion. This ensures that _most_ of an extension's resources are deleted. It does guarantee that global resources (e.g. CRDs, CRs, CRBs) are deleted. And would eventually allow the tests to be run in parallel (assuming the installed extensions allow for that). Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
fix-e2e-flakes
branch
from
2927437 to
c64e360
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fixes #1307 Create and use a new namespace for every e2e test. This means that extension resources are placed in their own namespace. The tests deletes the namespace, and then waits until completion. This ensures that _most_ of an extension's resources are deleted. It does guarantee that global resources (e.g. CRDs, CRs, CRBs) are deleted. And would eventually allow the tests to be run in parallel (assuming the installed extensions allow for that). Signed-off-by: Todd Short <tshort@redhat.com>
|
Managed to get this to run 35 times in a row without a failure... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307
Create and use a new namespace for every e2e test. This means that extension resources are placed in their own namespace. The tests deletes the namespace, and then waits until completion. This ensures that most of an extension's resources are deleted.
It does guarantee that global resources (e.g. CRDs, CRs, CRBs) are deleted.
And would eventually allow the tests to be run in parallel (assuming the installed extensions allow for that).
Description
Reviewer Checklist