Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump to go1.23 #1560

Closed

Conversation

perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner January 9, 2025 15:43
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 614814d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/678629ce3847a8000876da5f
😎 Deploy Preview https://deploy-preview-1560--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.64%. Comparing base (b83bd4e) to head (0ae1135).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1560   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files          42       42           
  Lines        3326     3326           
=======================================
  Hits         2516     2516           
  Misses        638      638           
  Partials      172      172           
Flag Coverage Δ
e2e 52.73% <ø> (ø)
unit 59.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilamacedo86
Copy link
Contributor

It is failing do we not need to fix the the CI first?

Per Goncalves da Silva added 3 commits January 14, 2025 10:07
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/bump-go1.23 branch from 0ae1135 to 614814d Compare January 14, 2025 09:09
@perdasilva perdasilva closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants