Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes reference to catalogd repo in the README #1602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Jan 13, 2025

We should not refer to catalogd repo since the monorepo implementation.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

We should not refer to catalogd repo since the monorepo implementation.
@bentito bentito requested a review from a team as a code owner January 13, 2025 15:06
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2ba4760
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67852be377eb0300083c704f
😎 Deploy Preview https://deploy-preview-1602--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (a67d023) to head (2ba4760).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
- Coverage   66.81%   66.68%   -0.14%     
==========================================
  Files          57       57              
  Lines        4584     4584              
==========================================
- Hits         3063     3057       -6     
- Misses       1298     1302       +4     
- Partials      223      225       +2     
Flag Coverage Δ
e2e 52.72% <ø> (-0.18%) ⬇️
unit 53.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably have many places to solve not this only this one
But
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants