Skip to content

Commit

Permalink
klint
Browse files Browse the repository at this point in the history
  • Loading branch information
Vishwajith-Shettigar committed Jun 26, 2024
1 parent de916f0 commit 32b3f4d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import org.oppia.android.app.hintsandsolution.RevealHintListener
import org.oppia.android.app.hintsandsolution.RevealSolutionInterface
import org.oppia.android.app.model.HelpIndex
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.QuestionPlayerActivityParams
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.ScreenName.QUESTION_PLAYER_ACTIVITY
import org.oppia.android.app.model.State
import org.oppia.android.app.model.WrittenTranslationContext
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ import org.oppia.android.app.hintsandsolution.HintsAndSolutionDialogFragment
import org.oppia.android.app.model.HelpIndex
import org.oppia.android.app.model.Profile
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.QuestionPlayerActivityParams
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.State
import org.oppia.android.app.model.WrittenTranslationContext
import org.oppia.android.app.player.exploration.DefaultFontSizeStateListener
import org.oppia.android.app.player.exploration.TAG_HINTS_AND_SOLUTION_DIALOG
import org.oppia.android.app.utility.FontScaleConfigurationUtil
import org.oppia.android.app.topic.questionplayer.QuestionPlayerActivity.Companion.QUESTION_PLAYER_ACTIVITY_PARAMS_KEY
import org.oppia.android.app.utility.FontScaleConfigurationUtil
import org.oppia.android.databinding.QuestionPlayerActivityBinding
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
Expand Down Expand Up @@ -72,7 +72,7 @@ class QuestionPlayerActivityPresenter @Inject constructor(
}
}

private fun loadQuestionPlayerFragment(readingTextSize: ReadingTextSize) {
private fun loadQuestionPlayerFragment(readingTextSize: ReadingTextSize) {
startTrainingSessionWithCallback {
activity.supportFragmentManager.beginTransaction().add(
R.id.question_player_fragment_placeholder,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import android.content.Intent
import android.os.Bundle
import org.oppia.android.app.activity.ActivityComponentImpl
import org.oppia.android.app.activity.InjectableAutoLocalizedAppCompatActivity
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.RevisionCardActivityParams
import org.oppia.android.app.model.ScreenName.REVISION_CARD_ACTIVITY
import org.oppia.android.app.player.exploration.BottomSheetOptionsMenuItemClickListener
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class RevisionCardFragment : InjectableDialogFragment() {
this.topicId = topicId
this.subtopicId = subtopicId
this.subtopicListSize = subtopicListSize
this.readingTextSize=readingTextSize
this.readingTextSize = readingTextSize
}.build()
return RevisionCardFragment().apply {
arguments = Bundle().apply {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import androidx.fragment.app.Fragment
import org.oppia.android.app.fragment.FragmentScope
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.model.ReadingTextSize
import org.oppia.android.app.model.RevisionCardFragmentArguments
import org.oppia.android.app.topic.conceptcard.ConceptCardFragment
import org.oppia.android.app.topic.revisioncard.RevisionCardFragment.Companion.REVISION_CARD_FRAGMENT_ARGUMENTS_KEY
import org.oppia.android.app.translation.AppLanguageResourceHandler
import org.oppia.android.app.utility.FontScaleConfigurationUtil
import org.oppia.android.databinding.RevisionCardFragmentBinding
Expand All @@ -18,13 +20,11 @@ import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.domain.translation.TranslationController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.extensions.getProto
import org.oppia.android.util.gcsresource.DefaultResourceBucketName
import org.oppia.android.util.parser.html.HtmlParser
import org.oppia.android.util.parser.html.TopicHtmlParserEntityType
import javax.inject.Inject
import org.oppia.android.app.model.RevisionCardFragmentArguments
import org.oppia.android.app.topic.revisioncard.RevisionCardFragment.Companion.REVISION_CARD_FRAGMENT_ARGUMENTS_KEY
import org.oppia.android.util.extensions.getProto

/** Presenter for [RevisionCardFragment], sets up bindings from ViewModel. */
@FragmentScope
Expand Down Expand Up @@ -135,6 +135,9 @@ class RevisionCardFragmentPresenter @Inject constructor(

private fun retrieveReadingTextSize(): ReadingTextSize {
return fragment.requireArguments()
.getProto(REVISION_CARD_FRAGMENT_ARGUMENTS_KEY,RevisionCardFragmentArguments.getDefaultInstance()).readingTextSize
.getProto(
REVISION_CARD_FRAGMENT_ARGUMENTS_KEY,
RevisionCardFragmentArguments.getDefaultInstance()
).readingTextSize
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ genrule(
name = "_sdk_info_properties",
srcs = [],
outs = ["sdk_info.properties"],
cmd = """
cmd =
"""
echo build_sdk_version={0} > \"$@\"
echo build_tools_version={1} >> \"$@\"
""".format(BUILD_SDK_VERSION, BUILD_TOOLS_VERSION),
Expand Down

0 comments on commit 32b3f4d

Please sign in to comment.