fix: Fix failing test on FeatureFlagsLoggerTest.

oppia · Jun 16, 2024 · 969ede4 · 969ede4
1 parent 34743c6
commit 969ede4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 25 deletions.
diff --git a/domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel b/domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/BUILD.bazel
@@ -304,7 +304,6 @@ oppia_android_test(
         "//domain/src/main/java/org/oppia/android/domain/oppialogger/analytics:prod_module",
         "//testing",
         "//testing/src/main/java/org/oppia/android/testing/data:data_provider_test_monitor",
-        "//testing/src/main/java/org/oppia/android/testing/junit:initialize_default_locale_rule",
         "//testing/src/main/java/org/oppia/android/testing/junit:oppia_parameterized_test_runner",
         "//testing/src/main/java/org/oppia/android/testing/junit:parameterized_robolectric_test_runner",
         "//testing/src/main/java/org/oppia/android/testing/logging:event_log_subject",
@@ -314,7 +313,6 @@ oppia_android_test(
         "//testing/src/main/java/org/oppia/android/testing/threading:test_coroutine_dispatchers",
         "//testing/src/main/java/org/oppia/android/testing/threading:test_module",
         "//testing/src/main/java/org/oppia/android/testing/time:test_module",
-        "//third_party:androidx_test_core",
         "//third_party:androidx_test_ext_junit",
         "//third_party:com_google_truth_truth",
         "//third_party:junit_junit",

diff --git a/...in/src/test/java/org/oppia/android/domain/oppialogger/analytics/FeatureFlagsLoggerTest.kt b/...in/src/test/java/org/oppia/android/domain/oppialogger/analytics/FeatureFlagsLoggerTest.kt
@@ -21,7 +21,6 @@ import org.oppia.android.testing.TestLogReportingModule
 import org.oppia.android.testing.junit.OppiaParameterizedTestRunner
 import org.oppia.android.testing.junit.OppiaParameterizedTestRunner.Iteration
 import org.oppia.android.testing.junit.OppiaParameterizedTestRunner.Parameter
-import org.oppia.android.testing.junit.OppiaParameterizedTestRunner.RunParameterized
 import org.oppia.android.testing.junit.OppiaParameterizedTestRunner.SelectRunnerPlatform
 import org.oppia.android.testing.junit.ParameterizedRobolectricTestRunner
 import org.oppia.android.testing.logging.EventLogSubject.Companion.assertThat
@@ -165,29 +164,27 @@ class FeatureFlagsLoggerTest {
   }
 
   @Test
-  @RunParameterized(
-    Iteration("downloads_support", "index=0", "flagName=$DOWNLOADS_SUPPORT"),
-    Iteration("extra_topic_tabs_ui", "index=1", "flagName=$EXTRA_TOPIC_TABS_UI"),
-    Iteration("learner_study_analytics", "index=2", "flagName=$LEARNER_STUDY_ANALYTICS"),
-    Iteration(
-      "fast_language_switching_in_lesson", "index=3",
-      "flagName=$FAST_LANGUAGE_SWITCHING_IN_LESSON"
-    ),
-    Iteration("logging_learner_study_ids", "index=4", "flagName=$LOGGING_LEARNER_STUDY_IDS"),
-    Iteration("edit_accounts_options_ui", "index=5", "flagName=$EDIT_ACCOUNTS_OPTIONS_UI"),
-    Iteration(
-      "enable_performance_metrics_collection", "index=6",
-      "flagName=$ENABLE_PERFORMANCE_METRICS_COLLECTION"
-    ),
-    Iteration("spotlight_ui", "index=7", "flagName=$SPOTLIGHT_UI"),
-    Iteration(
-      "interaction_config_change_state_retention", "index=8",
-      "flagName=$INTERACTION_CONFIG_CHANGE_STATE_RETENTION"
-    ),
-    Iteration("app_and_os_deprecation", "index=9", "flagName=$APP_AND_OS_DEPRECATION"),
-    Iteration("enable_nps_survey", "index=10", "flagName=$ENABLE_NPS_SURVEY"),
-    Iteration("enable_onboarding_flow_v2", "index=11", "flagName=$ENABLE_ONBOARDING_FLOW_V2"),
+  @Iteration("downloads_support", "index=0", "flagName=$DOWNLOADS_SUPPORT")
+  @Iteration("extra_topic_tabs_ui", "index=1", "flagName=$EXTRA_TOPIC_TABS_UI")
+  @Iteration("learner_study_analytics", "index=2", "flagName=$LEARNER_STUDY_ANALYTICS")
+  @Iteration(
+    "fast_language_switching_in_lesson", "index=3",
+    "flagName=$FAST_LANGUAGE_SWITCHING_IN_LESSON"
   )
+  @Iteration("logging_learner_study_ids", "index=4", "flagName=$LOGGING_LEARNER_STUDY_IDS")
+  @Iteration("edit_accounts_options_ui", "index=5", "flagName=$EDIT_ACCOUNTS_OPTIONS_UI")
+  @Iteration(
+    "enable_performance_metrics_collection", "index=6",
+    "flagName=$ENABLE_PERFORMANCE_METRICS_COLLECTION"
+  )
+  @Iteration("spotlight_ui", "index=7", "flagName=$SPOTLIGHT_UI")
+  @Iteration(
+    "interaction_config_change_state_retention", "index=8",
+    "flagName=$INTERACTION_CONFIG_CHANGE_STATE_RETENTION"
+  )
+  @Iteration("app_and_os_deprecation", "index=9", "flagName=$APP_AND_OS_DEPRECATION")
+  @Iteration("enable_nps_survey", "index=10", "flagName=$ENABLE_NPS_SURVEY")
+  @Iteration("enable_onboarding_flow_v2", "index=11", "flagName=$ENABLE_ONBOARDING_FLOW_V2")
   fun testLogFeatureFlags_allFeatureFlagNamesAreLogged() {
     featureFlagsLogger.logAllFeatureFlags(TEST_SESSION_ID)