-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove :voiceover_java_proto_lite from the list of exports in the model library #2768
Comments
I would like to work on this issue @prayutsu |
@prayutsu Please address the following queries as well
|
@Karanjot-singh, if you link a PR, I can answer all these questions for you. |
Thank you @fsharpasharp I am working on a new PR... I will link it soon |
Kindly refer #2999 |
… in the model library (#2999) * Remove voiceover_java_proto_lite from model exports * visibility removed in java_proto_lite & extra whitespace removed
This task is part of the build system migration from Gradle to Bazel. A prerequesite before working on this issue is that you are able to build Oppia using Bazel. Check out Oppia Bazel guide for Bazel terminology and more on what Bazel does.
1. Remove the export
In
/oppia-android/model/BUILD.bazel
Remove :voiceover_java_proto_lite from the list of exports in the model library
2. Add public visibility to the java_lite_proto_library
Add
visibility = ["//visibility:public"],
to the java_lite_proto_library that has the name voiceover_java_proto_lite.
3. Build the app using Bazel and run the tests
Libraries that are indirectly depending on
voiceover_java_proto_lite
will now fail to build. Try to build the entire app with Bazel and add the deps dependency//model:voiceover_java_proto_lite,
to all the libraries that are now failing to build. You will have to look around for BUILD.bazel files that have libraries that require this replaced dependency.
These libraries will already have the //model dependency and since we removed the :voiceover_java_proto_lite from the model library itself, they will need to add the newly available public library directly as a dependency. (Not all libraries with the //model dependency may require the newly available library)
Once the app builds and all tests pass, you're done!
The text was updated successfully, but these errors were encountered: