Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2768: Removed voiceover_java_proto_lite from the list of exports in the model library #2991

Closed

Conversation

Karanjot-singh
Copy link
Contributor

Explanation

Fixes #2768: Removed voiceover_java_proto_lite from the list of exports in the model library

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Karanjot-singh
Copy link
Contributor Author

PTAL @prayutsu The Bazel build was successful with the above changes

@Karanjot-singh Karanjot-singh marked this pull request as ready for review March 24, 2021 04:29
@prayutsu
Copy link
Contributor

@Karanjot-singh According to the 5th point of our Instructions for making a code change, we do not allow force push, so we'll have to close this PR.
You can create a fresh PR again..

@prayutsu prayutsu closed this Mar 24, 2021
@Karanjot-singh
Copy link
Contributor Author

Karanjot-singh commented Mar 24, 2021

@prayutsu I apologise for the force-push. Sure, I will create a fresh PR, I had a few queries:

  1. If I started working on an issue (and the feature branch is even with oppia:develop) and before I make the PR, there are a few commits oppia:develop, I need to rebase (auto merge) my feature branch before submitting the PR right?
  2. How do I lint check my BUILD.bazel file?
  3. The following unit Tests failed in this PR Could you help me with these so that I don't make the same mistakes in the new PR
    image
    image

@prayutsu
Copy link
Contributor

@Karanjot-singh Ideally you only require to make it even before you start working on the PR, bit for example, when you submit the PR and it takes too long to merge, so you may have to update it with the latest develop branch again.
Also, you don't need to rebase your branch, you can just merge the latest develop branch by git pull upstream develop

@Karanjot-singh Karanjot-singh deleted the remove-export-bazel branch March 24, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove :voiceover_java_proto_lite from the list of exports in the model library
3 participants