Fixes #4294: After deleting a profile deleted successfully message should be displayed

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

@@ -16,6 +16,7 @@ import org.oppia.android.app.model.ProfileId
 import org.oppia.android.databinding.ProfileEditFragmentBinding
 import org.oppia.android.domain.oppialogger.OppiaLogger
 import org.oppia.android.domain.profile.ProfileManagementController
+import org.oppia.android.domain.snackbar.SnackbarController
 import org.oppia.android.util.data.AsyncResult
 import org.oppia.android.util.data.DataProviders.Companion.toLiveData
 import javax.inject.Inject
@@ -29,7 +30,8 @@ class ProfileEditFragmentPresenter @Inject constructor(
   private val activity: AppCompatActivity,
   private val fragment: Fragment,
   private val oppiaLogger: OppiaLogger,
-  private val profileManagementController: ProfileManagementController
+  private val profileManagementController: ProfileManagementController,
+  private val snackbarManager: SnackbarManager
 ) {
 
   @Inject
@@ -151,6 +153,10 @@ class ProfileEditFragmentPresenter @Inject constructor(
         fragment,
         Observer {
           if (it is AsyncResult.Success) {
+            snackbarManager.showSnackbar(
+              R.string.profile_edit_delete_success,
+              SnackbarController.SnackbarDuration.LONG
+            )
             if (fragment.requireContext().resources.getBoolean(R.bool.isTablet)) {
               val intent =
                 Intent(fragment.requireContext(), AdministratorControlsActivity::class.java)

app/src/main/java/org/oppia/android/app/settings/profile/ProfileListActivity.kt

@@ -15,11 +15,14 @@ class ProfileListActivity :
   RouteToProfileEditListener {
   @Inject
   lateinit var profileListActivityPresenter: ProfileListActivityPresenter
+  @Inject
+  lateinit var snackbarManager: SnackbarManager
 
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
     (activityComponent as ActivityComponentImpl).inject(this)
     profileListActivityPresenter.handleOnCreate()
+    snackbarManager.enableShowingSnackbars(this)
   }
 
   override fun onSupportNavigateUp(): Boolean {

app/src/main/java/org/oppia/android/app/settings/profile/SnackbarManager.kt

@@ -0,0 +1,86 @@
+package org.oppia.android.app.settings.profile
+
+import android.view.View
+import androidx.annotation.StringRes
+import androidx.appcompat.app.AppCompatActivity
+import com.google.android.material.snackbar.Snackbar
+import org.oppia.android.domain.oppialogger.OppiaLogger
+import org.oppia.android.domain.snackbar.SnackbarController
+import org.oppia.android.util.data.AsyncResult
+import org.oppia.android.util.data.DataProviders.Companion.toLiveData
+import javax.inject.Inject
+
+private const val TAG = "SnackbarManager"
+private const val ERROR_MESSAGE = "can't be shown--no activity UI"
+
+/** Manager for showing snackbars. */
+class SnackbarManager @Inject constructor(private val snackbarController: SnackbarController) {
+
+  @Inject
+  lateinit var oppiaLogger: OppiaLogger
+
+  /**
+   *  Enqueues the snackbar that is be to shown in the FIFO buffer.
+   *
+   *  @param messageStringId The message string of string resource that is to be displayed
+   *  @param duration The duration for which snackbar is to be shown
+   */
+  fun showSnackbar(@StringRes messageStringId: Int, duration: SnackbarController.SnackbarDuration) {
+    snackbarController.enqueueSnackbar(
+      SnackbarController.SnackbarRequest.ShowSnackbar(
+        messageStringId,
+        duration
+      )
+    )
+  }
+
+  /**
+   * Enables the activity to show the snackbar.
+   *
+   * @param activity An activity that will observe for snackbars and display them
+   */
+  fun enableShowingSnackbars(activity: AppCompatActivity) {
+    snackbarController.getCurrentSnackbar().toLiveData().observe(activity) { result ->
+      when (result) {
+        is AsyncResult.Success -> when (val request = result.value) {
+          is SnackbarController.SnackbarRequest.ShowSnackbar -> showSnackbar(
+            activity.findViewById(
+              android.R.id.content
+            ),
+            request
+          )
+          SnackbarController.SnackbarRequest.ShowNothing -> {
+            if (snackbarController.snackbarRequestQueue.isNotEmpty()) {
+              snackbarController.dismissCurrentSnackbar()
+            }
+          }
+        }
+        else -> {}
+      }
+    }
+  }
+
+  private fun showSnackbar(
+    activityView: View?,
+    showRequest: SnackbarController.SnackbarRequest.ShowSnackbar
+  ) {
+
+    val duration = when (showRequest.duration) {
+      SnackbarController.SnackbarDuration.SHORT -> Snackbar.LENGTH_SHORT
+      SnackbarController.SnackbarDuration.LONG -> Snackbar.LENGTH_LONG
+    }
+
+    if (activityView == null) {
+      oppiaLogger.e(TAG, ERROR_MESSAGE)
+    } else {
+      Snackbar.make(activityView, showRequest.messageStringId, duration)
+        .addCallback(object : Snackbar.Callback() {
+          override fun onDismissed(transientBottomBar: Snackbar?, event: Int) {
+            super.onDismissed(transientBottomBar, event)
+            snackbarController.dismissCurrentSnackbar()
+          }
+        })
+        .show()
+    }
+  }
+}

app/src/main/res/values/strings.xml

@@ -625,4 +625,5 @@
   <string name="nps_score_question">On a scale from 0–10, how likely are you to recommend %s to a friend or colleague?</string>
   <string name="previous_subtopic_talkback_text">The previous subtopic is %s</string>
   <string name="next_subtopic_talkback_text">The next subtopic is %s</string>
+  <string name="profile_edit_delete_success">Profile has been successfully deleted.</string>
 </resources>

app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditFragmentTest.kt

@@ -25,6 +25,7 @@ import androidx.test.espresso.matcher.ViewMatchers.withText
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.google.common.truth.Truth.assertThat
 import dagger.Component
+import org.hamcrest.Matchers.allOf
 import org.hamcrest.Matchers.not
 import org.junit.After
 import org.junit.Before
@@ -121,14 +122,21 @@ import javax.inject.Singleton
 @Config(application = ProfileEditFragmentTest.TestApplication::class, qualifiers = "port-xxhdpi")
 class ProfileEditFragmentTest {
 
-  @get:Rule val initializeDefaultLocaleRule = InitializeDefaultLocaleRule()
-  @get:Rule val oppiaTestRule = OppiaTestRule()
-
-  @Inject lateinit var context: Context
-  @Inject lateinit var profileTestHelper: ProfileTestHelper
-  @Inject lateinit var profileManagementController: ProfileManagementController
-  @Inject lateinit var monitorFactory: DataProviderTestMonitor.Factory
-  @Inject lateinit var testCoroutineDispatchers: TestCoroutineDispatchers
+  @get:Rule
+  val initializeDefaultLocaleRule = InitializeDefaultLocaleRule()
+  @get:Rule
+  val oppiaTestRule = OppiaTestRule()
+
+  @Inject
+  lateinit var context: Context
+  @Inject
+  lateinit var profileTestHelper: ProfileTestHelper
+  @Inject
+  lateinit var profileManagementController: ProfileManagementController
+  @Inject
+  lateinit var monitorFactory: DataProviderTestMonitor.Factory
+  @Inject
+  lateinit var testCoroutineDispatchers: TestCoroutineDispatchers
 
   @Before
   fun setUp() {
@@ -158,6 +166,36 @@ class ProfileEditFragmentTest {
     }
   }
 
+  @Test
+  fun testProfileEdit_startWithUserProfile_clickProfileDeletionButton_deleteSnackbarIsVisible() {
+    launchFragmentTestActivity(internalProfileId = 1).use {
+      onView(withId(R.id.profile_delete_button)).perform(click())
+      testCoroutineDispatchers.runCurrent()
+      onView(withText(R.string.profile_edit_delete_dialog_positive))
+        .inRoot(isDialog())
+        .perform(click())
+      testCoroutineDispatchers.runCurrent()
+      onView(allOf(withText(R.string.profile_edit_delete_success)))
+        .check(matches(isDisplayed()))
+    }
+  }
+
+  @Test
+  fun testProfileEdit_startWithUserProfile_AfterDeleteSnackbar_profileActivityIsShownAgain() {
+    launchFragmentTestActivity(internalProfileId = 1).use {
+      onView(withId(R.id.profile_delete_button)).perform(click())
+      testCoroutineDispatchers.runCurrent()
+      onView(withText(R.string.profile_edit_delete_dialog_positive))
+        .inRoot(isDialog())
+        .perform(click())
+      testCoroutineDispatchers.runCurrent()
+      onView(allOf(withText(R.string.profile_edit_delete_success)))
+        .check(matches(isDisplayed()))
+      testCoroutineDispatchers.runCurrent()
+      intended(hasComponent(ProfileListActivity::class.java.name))
+    }
+  }
+
   @Test
   @Config(qualifiers = "land")
   fun testProfileEdit_configChange_startWithUserProfile_clickDelete_checkOpensDeletionDialog() {