Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5025: App and OS Deprecation Milestone 2 - Add protos and the DeprecationController #4999

Merged
merged 20 commits into from
Jul 12, 2023
Merged

Fix part of #5025: App and OS Deprecation Milestone 2 - Add protos and the DeprecationController #4999

merged 20 commits into from
Jul 12, 2023

Conversation

kkmurerwa
Copy link
Collaborator

@kkmurerwa kkmurerwa commented May 29, 2023

Explanation

Fix part of #5025: When this PR is merged, it will;

  • Add a new deprecation.proto file that will allow the storage of deprecation responses as well as provide the various deprecation types.
  • Add the OPTIONAL_UPDATE_AVAILABLE and the OS_IS_DEPRECATED startup modes on the onboarding.proto file for the two new startup modes being introduced.
  • Create a DeprecationController class and add tests for the class in the DeprecationControllerTest.
  • Modify BUILD.bazel files to provide the new proto files and the deprecation controller.
  • Add DeprecationControllerTest to the OppiaParameterizedTestRunner file exemptions on the file_content_validation_checks.textproto.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@kkmurerwa kkmurerwa requested a review from BenHenning as a code owner May 29, 2023 09:50
@kkmurerwa
Copy link
Collaborator Author

Hey @BenHenning and @adhiamboperes. Here is the PR for the second milestone of the App/OS Deprecation Feature. PTAL.

@BenHenning
Copy link
Member

Thanks @kkmurerwa! I'm going to be delegating this over to @adhiamboperes to approve since she'll be stepping in for me for codeowners starting this week through all of June.

@BenHenning BenHenning removed their assignment May 31, 2023
@BenHenning BenHenning requested a review from adhiamboperes May 31, 2023 07:56
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa.
I have only reviewed the protos since there are changes that may cause you to update some parts of your implementation. I have suggested a way to structure your deprecation responses, and also requested changes to the field documentation since some of the comments are not clear to me. I think we should aim for clarity on how these models are used because this is impotant for maintenability.

model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Show resolved Hide resolved
model/src/main/proto/onboarding.proto Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jun 1, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jun 1, 2023

Hi @kkmurerwa, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@kkmurerwa kkmurerwa changed the title App and OS Deprecation: Milestone 2 App and OS Deprecation: Milestone 2 - Add protos and the DeprecationController Jun 1, 2023
@BenHenning BenHenning removed their request for review June 2, 2023 03:43
@kkmurerwa
Copy link
Collaborator Author

Hey @adhiamboperes. This is ready for another pass. PTAL.

@kkmurerwa kkmurerwa requested review from a team as code owners June 2, 2023 06:21
@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Jun 2, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kkmurerwa, I have requested some changes, most of which are suggestins for improvements. PTAL, thanks.

model/src/main/proto/deprecation.proto Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
model/src/main/proto/deprecation.proto Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jun 3, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jun 3, 2023

Hi @kkmurerwa, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 3, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kkmurerwa, I have left a few further comments+some previoujs comments are not yet resolved. PTAL!

@adhiamboperes adhiamboperes assigned kkmurerwa and unassigned kkmurerwa Jul 3, 2023
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I have pushed an updated commit. Let me know if something else is remaining.

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Jul 4, 2023
@kkmurerwa kkmurerwa changed the title App and OS Deprecation: Milestone 2 - Add protos and the DeprecationController Fix part of #5025: App and OS Deprecation Milestone 2 - Add protos and the DeprecationController Jul 6, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kkmurerwa I have left one additional comment, but otherwise this LGTM.

@oppiabot
Copy link

oppiabot bot commented Jul 10, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jul 10, 2023
@oppiabot
Copy link

oppiabot bot commented Jul 10, 2023

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Jul 12, 2023
@adhiamboperes adhiamboperes enabled auto-merge (squash) July 12, 2023 14:47
@adhiamboperes adhiamboperes merged commit 9692306 into oppia:develop Jul 12, 2023
@kkmurerwa kkmurerwa deleted the app-and-os-deprecation-milestone-2 branch July 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants